feature: add toggle for disable mcp server tool from prompt #3551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 34da2f07f094e315fe2fed3899f9bf7a8475b314 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
bot
added
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Rexarrior
changed the title
Contributor
Author
|
Guys, should i do something more here? |
Member
|
Hey @Rexarrior, Thank you for your contribution. |
Member
|
I really like this, works without any issues. The only thing I would suggest for improvement is the naming of I made the switch look more like the one in Other than that this looks good to me. |
daniel-lxs
moved this from PR [Needs Preliminary Review]
to PR [Needs Review]
in Roo Code Roadmap
mrubens
reviewed
May 28, 2025
mrubens
reviewed
May 28, 2025
daniel-lxs
moved this from PR [Needs Review]
to PR [Changes Requested]
in Roo Code Roadmap
daniel-lxs
moved this from PR [Changes Requested]
to PR [Needs Prelim Review]
in Roo Code Roadmap
daniel-lxs
added
PR - Needs Preliminary Review
and removed
PR - Changes Requested
labels
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
mrubens
approved these changes
Jun 20, 2025
Collaborator
|
Is the test failure legit? |
Member
|
@mrubens |
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
daniel-lxs
force-pushed
the
very-clean-mcp-tool-toggle
branch
from
23b08da to
e757bd4
Compare
Member
|
@mrubens |
github-project-automation
bot
moved this from PR [Pre Approval Review]
to Done
in Roo Code Roadmap
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
cte
pushed a commit
that referenced
this pull request
Jun 24, 2025
* add toggle for disable mcp server tool from prompt * languages * fix error message * Update src/core/prompts/instructions/create-mcp-server.ts Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> * fix build * typo * refactor: make the switch style consistent * respect review * refactor: improve layout and styling in McpToolRow component * fix: update new mcp tests * tailwind css for disabledTool swipper * id locale (from main) * fix: improve error message for updating tool settings * fix: specify type for serverConfigData as Record<string, any> * fix: enhance UI layout and improve accessibility for tool controls * fix: migrate jest.Mock to vitest Mock type * Update .changeset/slimy-years-smell.md * fix: replace enabled switch with button --------- Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> Co-authored-by: Daniel <[email protected]> Co-authored-by: Daniel Riccio <[email protected]> Co-authored-by: Matt Rubens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #3346
Description
This PR introduces a new feature allowing users to toggle whether an individual MCP (Model Context Protocol) tool is included in the context provided to the AI model. This gives users finer-grained control over which tools the AI can see and potentially use.
The changes include:
McpHub.ts):disabledForPromptToolsarray to the MCP server configuration inmcp.json(both project and global).toggleToolEnabledForPromptmethod to add/remove tool names from thisdisabledForPromptToolslist.fetchToolsListto populate anenabledForPromptboolean on each tool object based on whether it's in thedisabledForPromptToolslist.mcp-servers.ts):tool.enabledForPromptflag.webviewMessageHandler.ts,WebviewMessage.ts):toggleToolEnabledForPromptmessage type and handler to facilitate communication between the webview UI and the extension backend.mcp.ts):enabledForPrompt?: booleanto theMcpTooltype.McpToolRow.tsx,mcp.jsoni18n):Test Procedure
Unit Tests:
McpHub.test.ts:Manual Testing Steps:
a. Locate the new toggle switch next to each tool (it might look like a slider).
b. Verify Initial State: Observe the initial state of the toggles.
c. Toggle Off: Click the toggle for a specific tool to disable its inclusion in the prompt.
i. Check the corresponding
mcp.jsonfile (either project's.roo/mcp.jsonor global MCP settings) to ensure the tool's name is added to thedisabledForPromptToolsarray for that server.ii.Verify that when a prompt is generated that would normally include MCP tools, this specific tool is now omitted from the context.
d. Toggle On: Click the toggle again for the same tool to re-enable its inclusion in the prompt.
i. Check the
mcp.jsonfile again to ensure the tool's name is removed from thedisabledForPromptToolsarray.ii. Verify the tool is now included in the prompt context.
.roo/mcp.json) and global MCP configurations if applicable.Type of Change
srcor test files.Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Screenshots / Videos
Before:
[Link to Before Screenshot/Video - e.g., showing the MCP tool row without the new toggle]
After:
[Link to After Screenshot/Video - e.g., showing the MCP tool row WITH the new toggle, and demonstrating its on/off states]
Documentation Updates
Additional Notes
This feature enhances user control over the AI's context, potentially improving relevance and reducing token usage by excluding unnecessary tools from prompts.
Important
Add toggle feature for MCP tool visibility in AI prompts, with updates to core logic, UI, and tests.
McpHub.ts):disabledForPromptToolsarray inmcp.jsonfor tool management.toggleToolEnabledForPromptto manage tool visibility in prompts.fetchToolsListto setenabledForPromptflag.mcp-servers.ts):enabledForPrompt.webviewMessageHandler.ts,WebviewMessage.ts):toggleToolEnabledForPromptmessage type for UI-backend communication.mcp.ts):enabledForPrompttoMcpTooltype.McpToolRow.tsx,mcp.jsoni18n):McpHub.test.ts):disabledForPromptTools.This description was created by
for 765157e0ed73cefff3af36d18eaf19ebbe858155. You can customize this summary. It will automatically update as commits are pushed.